Docs: Use docker.io/bash for sleep container of max-map-count-setter Daemonset
#7332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onset
On GKE Autopilot the Daemonset only works if a `docker.io/bash` image is used for the sleep container. For other images trying to apply this gives the follwing error message:
```
Error from server (GKE Warden constraints violations): error when creating "daemonset.yaml": admission webhook "warden-validating.common-webhooks.networking.gke.io" denied the request: GKE Warden rejected the request because it violates one or more constraints.
Violations details: {"[denied by autogke-disallow-privilege]":["container max-map-count-setter is privileged; not allowed in Autopilot"]}
```
florianmutter
changed the title
docker.io/bash for sleep container of max-map-count-setter Daemonsetdocker.io/bash for sleep container of max-map-count-setter Daemonset
|
buildkite test this please @florianmutter good catch it seems this was accidentally changed in the documentation in #6700 |
|
@elasticmachine, run elasticsearch-ci/docs |
pebrc
previously approved these changes
Nov 24, 2023
pebrc
reviewed
Nov 24, 2023
| @@ -92,7 +92,8 @@ spec: | |||
| command: ['/usr/local/bin/bash', '-e', '-c', 'echo 262144 > /proc/sys/vm/max_map_count'] | |||
| containers: | |||
| - name: sleep | |||
| image: gcr.io/google-containers/pause-amd64:3.2 | |||
| image: docker.io/bash:5.2.21 | |||
There was a problem hiding this comment.
can we use the same version as in the init container?
There was a problem hiding this comment.
👍 fixed. updated the init container to the latest bash image version as well
pebrc
approved these changes
Nov 24, 2023
|
Thank you @florianmutter for the contribution! |
|
buildkite test this |
|
@elasticmachine run elasticsearch-ci/docs |
robbavey
pushed a commit
to robbavey/cloud-on-k8s
that referenced
this pull request
Dec 20, 2023
…r Daemonset (elastic#7332) * Use `docker.io/bash` for sleep container of max-map-count-setter Daemonset On GKE Autopilot the Daemonset only works if a `docker.io/bash` image is used for the sleep container. For other images trying to apply this gives the follwing error message: ``` Error from server (GKE Warden constraints violations): error when creating "daemonset.yaml": admission webhook "warden-validating.common-webhooks.networking.gke.io" denied the request: GKE Warden rejected the request because it violates one or more constraints. Violations details: {"[denied by autogke-disallow-privilege]":["container max-map-count-setter is privileged; not allowed in Autopilot"]} ``` * Use latest docker.io/bash image for initContainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On GKE Autopilot the Daemonset only works if a
docker.io/bashimage is used for the sleep container. For other images trying to apply this gives the follwing error message:I could not find official documentation from Google on this but I tested myself and it only works this way.